We have some special rules around our /home
directories (using Debian), and the post-install script from Promtail fails on this line:
adduser --system --shell /bin/false "promtail"
I do not believe that Promtail uses the home directory at all. Is there any risk in changing the post-install to:
adduser --no-create-home --system --shell /bin/false "promtail"
And is it worth submitting such a change to the Promtail post-install script here ?
I haven’t tried, but since the script has a condition to check for user existence you could create the user ahead of time and that should take care of that.
I would say also that you should feel free to submit a pull request (with either an issue or feature request), and it’s up to the Grafana team to decide whether they want to merge.
1 Like
Yep, I thought a pull request was in order:
grafana:main
← alvintownsend:patch-1
opened 03:35PM - 26 Jun 23 UTC
**What this PR does / why we need it**:
When the `promtail-postinstall` scrip… t creates a `promtail` user, I do not believe that user requires a home directory to function correctly, and there are cases where the directory cannot be created causing the installation to fail.
**Which issue(s) this PR fixes**:
n/a - trivial fix
**Special notes for your reviewer**:
**Checklist**
- [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**)
It solves at least that issue.
1 Like
system
Closed
June 26, 2024, 1:19pm
4
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.